Hi All,
The git repository (tag radsecproxy-1.6.7) does not compile on RedHat, due to docbook2x_man tool detection fails. The tool is called during compile, regardless of whether it was not found or provided manually to configure.
Also, docbook2man on RedHat is not happy with the radsecproxy.conf.5.xml (see patch). docbook2man version info: usr/bin/db2x_docbook2man (part of docbook2X 0.8.8) $Revision: 1.12 $ $Date: 2006/04/14 17:29:04 $
Patch is attached. Please verify if this works on other platforms.
Best regards, Fabian
Fabian Mauchle fabian.mauchle@switch.ch wrote Tue, 13 Sep 2016 15:03:18 +0200:
The git repository (tag radsecproxy-1.6.7) does not compile on RedHat, due to docbook2x_man tool detection fails. The tool is called during compile, regardless of whether it was not found or provided manually to configure.
Good catch and nice fix. Part of it applied.
I'm curious about the test for "$DOCBOOK2X_MAN" being false though. I'd like to replace that with "test -z" if you too think that's equivalent:
if test -z "$DOCBOOK2X_MAN" ; then
What do you think?
Also, docbook2man on RedHat is not happy with the radsecproxy.conf.5.xml (see patch). docbook2man version info: usr/bin/db2x_docbook2man (part of docbook2X 0.8.8) $Revision: 1.12 $ $Date: 2006/04/14 17:29:04 $
I don't expect removing "<application>" to break things. Patch applied.
Thanks for good bug report and fixes!
Hi Linus,
On 16/09/16 12:15, Linus Nordberg wrote:
I'm curious about the test for "$DOCBOOK2X_MAN" being false though. I'd like to replace that with "test -z" if you too think that's equivalent:
if test -z "$DOCBOOK2X_MAN" ; then
What do you think?
It seems (like in most languages) that a non-zero (or non-zero-length string) value is interpreted as true, so at least it works (for me). But I fully agree that "test -z" is the better way to do this.
Best regards, Fabian
Fabian Mauchle fabian.mauchle@switch.ch wrote Fri, 16 Sep 2016 16:02:29 +0200:
Hi Linus,
On 16/09/16 12:15, Linus Nordberg wrote:
I'm curious about the test for "$DOCBOOK2X_MAN" being false though. I'd like to replace that with "test -z" if you too think that's equivalent:
if test -z "$DOCBOOK2X_MAN" ; then
What do you think?
It seems (like in most languages) that a non-zero (or non-zero-length string) value is interpreted as true, so at least it works (for me). But I fully agree that "test -z" is the better way to do this.
Thanks. Merged to master.
Linus Nordberg linus@nordu.net wrote Mon, 19 Sep 2016 09:54:20 +0200:
Thanks. Merged to master.
(And maint-1.6.)
-
Fabian Mauchle -
Linus Nordberg